Skip to content

docs: extend Adopting the framework section for PR-skill adopter contract#34

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:docs/extend-adopting-section-for-pr-skills
May 2, 2026
Merged

docs: extend Adopting the framework section for PR-skill adopter contract#34
potiuk merged 1 commit into
apache:mainfrom
potiuk:docs/extend-adopting-section-for-pr-skills

Conversation

@potiuk

@potiuk potiuk commented May 2, 2026

Copy link
Copy Markdown
Member

Summary

  • Restructure the top-level README's ## Adopting the framework section into four subsections: Bootstrapping a new adopter (concrete commands), Per-skill-family contract (security vs PR triage families), How skills resolve <project-config>/ paths, and Keeping the submodule current (preserves the existing post-merge-hook guidance).
  • projects/_template/README.md: add a ### PR triage and review subsection listing the four scaffold files added in feat(skills): lift pr-triage, pr-stats, pr-maintainer-review #33 (pr-triage-config.md, pr-triage-comment-templates.md, pr-triage-ci-check-map.md, pr-maintainer-review-criteria.md) with per-file purpose. Split the "Checklist after copying" into three groups (security / PR / common finishers) so adopters using only one family can skip the other.
  • doctoc TOCs regenerated for both files.

Context

The four PR-skill scaffold files landed in #33 but the adoption flow was only briefly mentioned. This PR documents the contract end-to-end so a non-airflow project can:

  1. Read the bootstrap walk-through with concrete git submodule add / cp -r / ln -s commands.
  2. Follow the per-skill-family table to know which <project-config>/ files apply to their use case.
  3. Find the "what does each file do" detail in the adopter-side projects/_template/README.md.
  4. Run a checklist that flags the minimum content each family needs.

Both surfaces carry the same disclaimer that the framework currently embeds airflow-flavoured defaults inline in the PR-skill supporting files; a follow-up PR completes the extraction. Until then, non-airflow adopters override by forking the relevant supporting file into their own .claude/skills/<skill-name>/.

Test plan

  • All pre-commit hooks pass (markdownlint, typos, doctoc, check-placeholders)
  • doctoc regenerates both TOCs cleanly
  • No new anchors broken — existing #adopting-the-framework and #pr-triage-and-review anchors preserved
  • Reviewer eyeballs the per-skill-family table for accuracy of "which file for which skill"
  • CI link-check (lychee) passes

🤖 Generated with Claude Code

…ract

Two doc surfaces updated to surface the four PR-skill scaffold
files added in apache#33:

- **Top-level README `## Adopting the framework`** — restructured
  into four subsections:
  - `Bootstrapping a new adopter` — three concrete steps (submodule
    add, copy `_template/`, symlink `.claude/skills/`) with the
    actual commands;
  - `Per-skill-family contract` — splits the adopter's required
    `<project-config>/` files by skill family (security workflow vs
    PR triage and review). Adopters who use only one family can
    delete the other family's scaffold;
  - `How skills resolve <project-config>/ paths` — explains the
    pure-text placeholder convention so adopters don't go hunting
    for an env var or build step;
  - `Keeping the submodule current` — preserves the existing
    `git submodule update --init --recursive` post-merge-hook
    guidance.
- **`projects/_template/README.md`** — adds a `### PR triage and
  review` subsection listing the four PR-skill scaffold files
  (`pr-triage-config.md`, `pr-triage-comment-templates.md`,
  `pr-triage-ci-check-map.md`, `pr-maintainer-review-criteria.md`)
  with per-file purpose and which skills consume them. The
  "Checklist after copying" splits into three groups (security
  workflow / PR triage and review / common finishers) so adopters
  who only use one family can skip the other group's checks.

doctoc TOCs regenerated.

Both surfaces carry the same disclaimer that the framework
currently embeds airflow-flavoured defaults inline in the PR-
skill supporting files; a follow-up PR completes the extraction.
Until then non-airflow adopters override by forking the relevant
supporting file into their own `.claude/skills/<skill-name>/`.

Generated-by: Claude Code (Claude Opus 4.7)
@potiuk potiuk merged commit 9774cc9 into apache:main May 2, 2026
7 checks passed
@andreahlert andreahlert added the mode:platform Substrate / infra — not a mode (sandbox, CI, validators) label May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mode:platform Substrate / infra — not a mode (sandbox, CI, validators)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants